fix(grcc): bounds checking for coupling, nodes, etc - #901
Open
jodavies wants to merge 1 commit into
Open
Conversation
Cases where we check an array index against, for eg, GRCC_MAXNCPLG should use > and not >=. Cases where we are inserting a new vector entry must remain >= since we about to increment, and then index. Also increase the default GRCC_MAXNCPLG and GRCC_MAXLEGS to 15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cases where we check an array index against, for eg, GRCC_MAXNCPLG should use > and not >=. Cases where we are inserting a new vector entry must remain >= since we about to increment, and then index.
Also increase the default GRCC_MAXNCPLG and GRCC_MAXLEGS to 15.
Not all cases should be
>rather than>=. For eg, hereform/sources/grcc.cc
Lines 2135 to 2137 in b7753d5
we check for
nParticles >= GRCC_MAXMPARTICLESbecause below we increment before usingnParticlesas an index:form/sources/grcc.cc
Lines 2168 to 2169 in b7753d5
Fixes #887