Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Episode reads currently default to the latest episode even when a caller has a committed dataset's pinned version. Add optional
episode_versiontoiter_messages,download_data, andget_topics, forwarding it asepisodeVersion. Omitting it preserves latest-version behavior; specifying it requiresepisode_idand works with explicit time bounds for lookback.Validation: all 144 client tests pass; black, flake8, and pyright pass in the Python 3.8 CI environment. GitHub CI passes. Existing dataset download pin handling and membership deserialization already preserve versions.
Live verification against
https://api.foxglove.partypassed with the fixed SDK and disposable fixtures: pinned versus latest counts were 257 versus 157 after a time-window edit and 1,679 versus 126 after a recording-membership edit. Pinned content digests remained stable across repeated reads and replanning; explicit pinned topic discovery also passed. All temporary datasets/episodes were deleted and the supplied original artifacts remained unchanged.Part of DC-2016. Keep draft. SDK integration depends on releasing this client support; no release version is assumed.