Skip to content

fix: use printf for parity between different shell contexts - #291

Open
julzerinos wants to merge 1 commit into
game-ci:mainfrom
julzerinos:patch-1
Open

julzerinos wants to merge 1 commit into
game-ci:mainfrom
julzerinos:patch-1

Conversation

@julzerinos

@julzerinos julzerinos commented Oct 21, 2026 •

Copy link
Copy Markdown

Changes

  • Use printf instead of echo to support newline behaviour across both sh and bash, otherwise in bash the newline \n is treated literally without the escape flag (-e) which in turn is not supported by sh. This change lets developers extend the hub image (and game-ci/base image) from another base image ($ubuntuImage in game-ci/base) with an arbitrary shell.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

Summary by CodeRabbit

  • Refactor
    • Updated Unity Hub wrapper output handling without changing its commands or arguments.

@github-actions

Copy link
Copy Markdown

Cat Gif

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 99395c34-d7b3-443c-a71c-41e2b50c53e9
📥 Commits

Reviewing files that changed from the base of the PR and between 75891f0 and a6d8c7c.

📒 Files selected for processing: 1
  • images/ubuntu/hub/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The Unity Hub wrapper script is now generated with printf instead of echo. Its headless xvfb-run invocation and argument forwarding remain unchanged.

Changes: Unity Hub wrapper

Layer / File(s) Summary
Wrapper script generation
images/ubuntu/hub/Dockerfile
The script is generated with printf. The invocation and argument forwarding remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: andrewkahr

Merge Risk: ⚪ Minimal · up to a6d8c

No actionable merge-blocking risk is identified in this change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: replacing echo with printf for consistent behavior across shell contexts.
Description check Passed The description includes both required sections, explains the change and its purpose, and completes the checklist.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants