You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: use printf for parity between different shell contexts - #291
Use printf instead of echo to support newline behaviour across both sh and bash, otherwise in bash the newline \n is treated literally without the escape flag (-e) which in turn is not supported by sh. This change lets developers extend the hub image (and game-ci/base image) from another base image ($ubuntuImage in game-ci/base) with an arbitrary shell.
Checklist
Read the contribution guide and accept the code of conduct
Readme (updated or not needed)
Summary by CodeRabbit
Refactor
Updated Unity Hub wrapper output handling without changing its commands or arguments.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 99395c34-d7b3-443c-a71c-41e2b50c53e9
📥 Commits
Reviewing files that changed from the base of the PR and between 75891f0 and a6d8c7c.
📒 Files selected for processing: 1
images/ubuntu/hub/Dockerfile
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
📝 Walkthrough
The Unity Hub wrapper script is now generated with printf instead of echo. Its headless xvfb-run invocation and argument forwarding remain unchanged.
No actionable merge-blocking risk is identified in this change.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: replacing echo with printf for consistent behavior across shell contexts.
Description check
The description includes both required sections, explains the change and its purpose, and completes the checklist.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
printfinstead ofechoto support newline behaviour across bothshandbash, otherwise inbashthe newline\nis treated literally without the escape flag (-e) which in turn is not supported bysh. This change lets developers extend the hub image (and game-ci/base image) from another base image ($ubuntuImagein game-ci/base) with an arbitrary shell.Checklist
Summary by CodeRabbit