Repository navigation
feat(render): embed favicon in local preview HTML - #138
Merged
Merged
Conversation
Inline a 32x32 PNG as a data URI in buildHTML so file://, -outfile, and --watch tabs show the gander mark. Closes #137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
favicon.png) and inline it as a data URI inthemeHead/buildHTML.gander <file>,gander --watch,-outfile) show the gander favicon without fetching/favicon.ico, which would breakfile://and-outfile.Related Issue
Closes #137
Testing
All green.
TestBuildHTMLFaviconpinsrel="icon",data:image/png;base64,, the embedded bytes, and the absence of/favicon.ico.Notes
Hosted gander.md pages are gandermd/gandermd#152. This PR does not add a
/favicon.icoroute on the runner.