Repository navigation
feat(cli): add Share with your team to local previews - #146
Merged
Merged
Conversation
Unsigned one-shot, foreground watch, and runner previews show a signup button that runs the same flow as gander signup --email. The API token is saved in the CLI config and is not returned to the page. Closes #145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gander signup --email: create a signup intent, open the signup form, poll until the token exists, and save it in~/.gander/config.json.--watch, and runner/w/<id>pages. Signed-up previews and-outfileomit it.api_token. The runner signup route keeps the existing watch-token check.127.0.0.1by a short-lived helper, because afile://page exits before signup can save the token. The helper exits after it has been idle for about as long as the signup poll.Related Issue
Closes #145
Testing
go test ./...go vet ./...mandoc -Tlint man/man1/gander.1Notes
Uploading the open file (
gander share) is out of scope. This button only starts signup.