Repository navigation
feat(cli): forward install source on signup and share - #147
Merged
Merged
Conversation
Send install_source only when --source or GANDER_SOURCE is set, so older servers keep accepting the request. Directory watches persist the source for the runner's first POST. Refs gandermd#169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gander signupand hostedgander share/gander watchsendinstall_sourcewhen--sourceorGANDER_SOURCEis set. The flag wins. Neither set means the JSON key is omitted, so an older server still accepts the request.POST /api/shares. Later content pushes stay onPUTand do not send the field. Local preview does not send it.Related
Server change: https://github.com/gandermd/gandermd/pull/171
Issue: https://github.com/gandermd/gandermd/issues/169
This PR does not auto-close that issue. Ship the server before a CLI release that sends the field.
Testing
go test ./...go vet ./...go build ./...