Sanitize URIs in <meta http-equiv="refresh" ...> and image candidate string attributes - #957
Merged
Merged
Conversation
…e string attributes
giuscris
added a commit
that referenced
this pull request
Sep 26, 2026
…cset Sanitize URIs in `<meta http-equiv="refresh" ...>` and image candidate string attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the security and flexibility of HTML and SVG sanitization by improving how URI attributes are validated and by adding special handling for certain attributes such as
srcset,imagesrcset, and meta refresh tags. The main changes include refactoring URI safety checks, extending attribute whitelists, and adding more granular logic for complex attributes.Improvements to URI attribute validation:
DomSanitizer: introduced a dedicatedisSafeUriAttributemethod for checking URI safety, and moved URI decoding logic to a newdecodeUrimethod. The validation now consistently checks allowed schemes and external URI policy. (formwork/src/Sanitizer/DomSanitizer.php) [1] [2]HTML-specific attribute handling:
HtmlSanitizer, added custom logic to handle<meta http-equiv="refresh" content="...">by removing thecontentattribute if the refresh URI is unsafe, and improved validation forsrcsetandimagesrcsetattributes by checking each URI in the list. (formwork/src/Sanitizer/HtmlSanitizer.php)Extension of URI attribute whitelist:
srcsetandimagesrcsetto the list of recognized URI attributes inHtmlReference, ensuring these are properly sanitized. (formwork/src/Sanitizer/Reference/HtmlReference.php)SVG attribute sanitization fix:
formwork/src/Sanitizer/SvgSanitizer.php)Dependency and import updates:
DOMAttrandDOMElementinHtmlSanitizerto support the new logic. (formwork/src/Sanitizer/HtmlSanitizer.php)