Footer: Group links by destination. - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The React footer currently forces a full navigation for in-page section links and the standalone footer consistency claim doesn’t cover public/thanks/index.html.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR restructures the site footer to group links by destination (home-page sections, on-site pages, and offsite resources) and adds small external-link icons for offsite destinations, applying the updated footer styling across the app shell and several standalone pages.
Changes:
- Refactored the React app footer into grouped navigation sections and added external-link icons for Docs/GitHub.
- Added a shared
public/footer.cssstylesheet and linked it from the app entry and updated standalone pages. - Updated standalone pages’ footer markup to match the new grouped navigation structure.
File summaries
| File | Description |
|---|---|
| src/App.tsx | Refactors footer markup into grouped nav sections and adds external-link icons. |
| public/privacy/index.html | Links footer.css and updates footer to grouped navigation structure. |
| public/footer.css | Introduces shared footer layout/styles for grouped navigation and external-link icons. |
| public/features/index.html | Links footer.css and updates footer to grouped navigation structure. |
| public/download/index.html | Links footer.css and updates footer to grouped navigation structure. |
| public/cli/index.html | Links footer.css and updates footer to grouped navigation structure. |
| index.html | Links footer.css for the app shell so the React footer gets the new styling. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group footer links by destination: home-page Download and Feedback sections, Features/CLI/Privacy pages, and offsite Docs/GitHub links with small external-link icons. Move “Do not press” beside “Copy irresponsibly.” on the left.
Keep the original small text styling and omit hover underlines. Apply the grouped navigation consistently to the standalone pages.
Validation:
npm test(unit and preview-routing tests, TypeScript, production build, page/asset isolation and footer destination audits);git diff --check.