fix(lint): force-ignore output.ts from Biome type analysis (200k limit) - #1536
Merged
Conversation
output.ts trips Biome's project-mode type-inference limit (unusually large amount of types which exceeded the limit of 200,000) once valibot's GenericSchema graph is pulled in — the same internal Biome bug already handled for custom-ca.ts. It surfaces non-deterministically: main passes by a hair, but unrelated PRs trip it (e.g. #1499, #1501, #1535), failing Lint & Typecheck with no real lint violation. Force-ignore it the same way as custom-ca.ts; Biome now checks 1025 files with no errors. output.ts stays covered by tsc. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lint & Typecheckfails on an internal Biome error, with no real lint violation in the changed code:output.tsimports valibot'sGenericSchema, whose recursive generic graph pushes Biome's project-mode type inference over its 200,000-type ceiling — the same internal Biome bug already handled forcustom-ca.tsin this config (see the existing"!!src/lib/custom-ca.ts"force-ignore).It surfaces non-deterministically:
mainpasses by a hair, but the exact type count tips over on PR runners, so unrelated PRs fail this job identically — e.g. #1499, #1501, and #1535. Re-running does not clear it (deterministic per branch state).Fix
Force-ignore
src/lib/formatters/output.tsthe same way ascustom-ca.ts, until Biome raises/fixes the limit.Verification
pnpm run lint(the CI invocation) now passes:Unblocks #1535 (and the other PRs above) once merged. Trade-off is the same one already accepted for
custom-ca.ts:output.ts(a leaf formatter) is skipped by Biome; it stays covered bytsc.🤖 Generated with Claude Code