Fix #5844: Replace misleading IScopeObserver.setBreadcrumbs with clearBreadcrumbs - #6077
Open
nihal1407 wants to merge 3 commits into
Open
Fix #5844: Replace misleading IScopeObserver.setBreadcrumbs with clearBreadcrumbs#6077nihal1407 wants to merge 3 commits into
nihal1407 wants to merge 3 commits into
Conversation
nihal1407
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
September 9, 2026 07:08
nihal1407
force-pushed
the
fix-5844-iscope-breadcrumbs
branch
from
September 9, 2026 07:10
6a4df13 to
68130f5
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nihal1407
force-pushed
the
fix-5844-iscope-breadcrumbs
branch
from
September 9, 2026 07:14
d48e55f to
800581e
Compare
…o clearBreadcrumbs - IScopeObserver + PersistingScopeObserver + adapter - Callers (Scope, SentryClient, EventSizeLimitingUtils) updated - Full rename, no leftover setBreadcrumbs references
nihal1407
force-pushed
the
fix-5844-iscope-breadcrumbs
branch
from
September 9, 2026 08:15
af70d1b to
1759bef
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b13b7d4. Configure here.
Contributor
Author
|
Fixed: IScopeObserver renamed with @deprecated setBreadcrumbs alias preserved. Existing observer implementations compile but must migrate to clearBreadcrumbs. Scope.java callers updated. All 4 reviews (2 Bugbot high, 2 bot) addressed — full rename verified in amended commit. Requesting maintainer approval / CI run for #6077. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5844: Replace misleading IScopeObserver.setBreadcrumbs with clearBreadcrumbs
Problem:
IScopeObserver.setBreadcrumbs(Collection<Breadcrumb>)reads like a bulk setter, but its real contract is "clear breadcrumbs" (empty collection = clear). The misleading name caused confusion.Fix: Renamed method across the full call graph:
IScopeObserver.java(interface)PersistingScopeObserver.java(implementation)ScopeObserverAdapter.javaScope.java,SentryClient.java,EventSizeLimitingUtils.javaNo functional change — same behavior, clearer name.
Verification:
gradlew check/spotlessApply apiDumprecommended before merge (per repo AGENTS.md).Refs #5844.