ref(core): Type metric units with MetricUnit - #23304
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/type-metric-units
branch
from
August 24, 2026 18:41
8991df5 to
1357436
Compare
logaretm
marked this pull request as ready for review
August 24, 2026 19:40
Lms24
approved these changes
Aug 28, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
LGTM! Given that LiteralUnion still permits adding any kind of string also means we can extend the unit range without an SDK major version.
(The concern if it only accepted the string literals was that beforeSendMetric could break for users who rely on the current set of string literals)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types the
unitfield on the metrics API (MetricOptions,Metric,SerializedMetric) instead of leaving it as a barestring.It reuses the existing
LiteralUnionhelper so the canonical units that match the develop docs get autocomplete while arbitrary strings still pass through, which the spec requires ("SDKs MUST NOT restrict unit values").I did not reuse
MeasurementUnithere as it carries aNoneUnit('' | 'none') that is a leftover from the old transaction-measurement system and is not a valid metric unit.This doesn't change anything about the API, is still accepts
stringbut just provides autocomplete on the common values we use throughout our codebase, it's mostly a DX change for us.