Repository navigation
Open-source cleanup of the modules repo - #70
Merged
Merged
Conversation
Drop private CI infrastructure, resolve dependencies from public npm, move the Minecraft dev environment under dev/minecraft, run CI without secrets, and add LICENSE, CONTRIBUTING and rewritten docs.
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns gettakaro/modules into a repository an outsider can clone, install, build and contribute to, as the open-source home of Takaro's Official Registry. All private CI infrastructure and private package dependencies are gone, CI runs without secrets (so fork PRs go green), and the repo now has an MIT LICENSE, CONTRIBUTING.md and rewritten README/AGENTS.md. Terminal state: implemented and verified locally; CI pending.
Closes #66
Part of gettakaro/takaro#4616
What Changed
docker-compose.ci.yml,containers/(Kratos),scripts/ci-bootstrap.sh,src/scripts/ci-create-domain.ts, stale.claude/plans/.@takaro/apiclient(public npm, devDependency,^0.7.5) anddotenvremain; the other seven private@takaro/*packages andpgare dropped..npmrcpins the@takaroscope to public npm; lockfile regenerated (onlyregistry.npmjs.org). No--legacy-peer-depsneeded.check: build, typecheck, offline tests;minecraft-bot: bot unit test).test/module-conversion.test.tsconverts every module directory with the existing converter and checks the output shape.npm testis now this; the old live suite moved tonpm run test:liveand is dormant (needs Takaro's mock game server package, not on public npm), with a README intest/.bot/, Paper compose, plugin download and instance scripts moved todev/minecraft/with its own.env.exampleand README. Redis moved totest/docker-compose.yml..claude/skillspaths updated.Out of scope and untouched: registry build/validator/Pages (modules#67), moving built-ins (modules#68), any module content.
Reviewer Guide
.github/workflows/ci.yml,package.json,test/module-conversion.test.ts.git diff main --stat -- modules test/helpersshows onlymodules/README.md; live tests are intentionally unchanged.Testing Plan
Happy Path
rm -rf node_modules && NPM_CONFIG_USERCONFIG=/dev/null npm cisucceeds with no private registry.npm run build && npm run typecheck && npm testpass; one passing case per module directory.cd dev/minecraft/bot && npm ci && npm testpasses.Edge Cases
docker compose -f dev/minecraft/docker-compose.yml config -qanddocker compose -f test/docker-compose.yml config -qparse.bash -npasses forscripts/*.shanddev/minecraft/*.sh.git grep -niE 'kratos|mailhog|codeartifact|dkr\.ecr|AWS_|ai-module-writer|ci-bootstrap'returns nothing.Regression Checks
ls modules/*/test/*.test.ts | wc -lis still 35.scripts/module-push.shandnpm run module:to-json -- modules/hello-worldstill work.Housekeeping
Renovate onboarding PR #1 is closed with
ghafter this PR is opened (the repo does not use Renovate; no bot config is added).