Add optional Prometheus metrics for client operations - #901
Open
Poseidonas wants to merge 2 commits into
Open
Poseidonas wants to merge 2 commits into
Poseidonas wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional Prometheus metrics for client operations, following up on #843.
snap7/metrics.pyaccumulates per-operation counters and durations (MetricsRegistry) and can serve them asGET /metrics(MetricsServer, stdlibhttp.server, no new dependency).Clienttakes an optionalmetrics=argument. Instrumentation sits inread_area/write_area, coveringdb_read/db_writeand the typed wrappers on top of them without touching each one individually. Asnap7_client_connectedgauge updates on connect/disconnect/reconnect.Scope note: this tracks client call counts, errors, latency, and connection state — not PLC tag values, so it's separate from the exporter described in #623.
16 new tests in
tests/test_metrics.py. Full suite still passes (1399/1399, excluding e2e).