Forward OAuth client metadata URL in all SDK sessions - #2258
Forward OAuth client metadata URL in all SDK sessions#2258SamMorrowDrums wants to merge 16 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds Rust SDK support for forwarding OAuth client metadata URLs during session creation and resume.
Changes:
- Adds optional configuration fields and builders.
- Serializes the value in create/resume wire payloads while omitting
None. - Adds serialization coverage for configured values.
Show a summary per file
| File | Description |
|---|---|
rust/src/wire.rs |
Adds optional camelCase wire fields. |
rust/src/types.rs |
Exposes, forwards, and tests the new setting. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f531cfac-d107-4676-963c-a6c10cc92148
Retain OAuth client metadata URL forwarding in create and resume payloads, including custom Debug output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f531cfac-d107-4676-963c-a6c10cc92148
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 716e07c8-226b-4a6f-beb0-877ccee1eb6e
…lient-metadata-url
…lient-metadata-url
Document that external SDK users remain generic and isolated unless they explicitly provide a host client metadata URL, including on resume. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 716e07c8-226b-4a6f-beb0-877ccee1eb6e
|
Thanks for adding this to the Rust SDK — the implementation is clean and follows the existing optional-field pattern well (builder method, correct Per our contribution guidelines, features need to land consistently across all supported SDKs rather than in a single language, so this shouldn't merge Rust-only. Could you also expose and forward For coverage, please add create/resume wire-serialization unit tests per language (mirroring the Rust test here), and only add E2E coverage where the runtime dependency ( Once parity across languages and per-language tests are in place, please mark this ready for review again and we'll take another look. Thanks again for driving this! |
…lient-metadata-url
Expose the optional host identity on create and resume in Node, Python, Go, .NET, Java, and Rust while omitting it when unset for older-runtime compatibility. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 716e07c8-226b-4a6f-beb0-877ccee1eb6e
This comment has been minimized.
This comment has been minimized.
Avoid deprecated no-ID create request helpers in OAuth client metadata serialization coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 716e07c8-226b-4a6f-beb0-877ccee1eb6e
Cross-SDK Consistency Review ✅This PR uniformly adds
Naming follows each language's idiomatic convention (camelCase for TS/Java, snake_case for Python/Rust, PascalCase for Go/exported fields, PascalCase for .NET). The JSON wire name All six SDKs also include focused serialization tests verifying both the configured-value and unset-omission cases. No cross-SDK consistency issues found.
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore the reviewer-ready CIMD feature tree while preserving the published workflow experiment history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Summary
session.createandsession.resumeDependencies
92879e7bed882e63ff3e1cba25ee2bef504f213f; closes dedicated subtask github/copilot-agent-runtime#17439Runtime #14687 is required for the value to affect MCP OAuth. Older runtimes ignore this additive optional request field.
Validation
ty check copilotgo test ./...The branch is merged with current SDK main and validated against CLI 1.0.83-3.