Swift Package Support, switch to ARC - #21
Merged
Merged
Conversation
hannesa2
force-pushed
the
SwiftPackageSupport
branch
from
December 20, 2023 08:11
b8e9520 to
d8a83c2
Compare
hannesa2
force-pushed
the
SwiftPackageSupport
branch
from
September 21, 2026 04:28
d8a83c2 to
20670b4
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
ARC is not enabled for the existing Xcode target, and the package includes an unsupported deployment contract and an unbuildable demo resource.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Adds Swift Package Manager support and updates Objective-C ownership code for ARC-based builds.
Changes:
- Adds
Package.swift, package resources, public headers, and tests. - Removes manual memory-management calls.
- Adds README documentation and demo resources.
| File | Description |
|---|---|
Package.swift |
Defines the library, resources, platform, and tests. |
Sources/MGScopeBar/MGScopeBar.m |
Updates ownership handling for ARC. |
Sources/MGScopeBar/MGScopeBar.h |
Marks the delegate as unsafe unretained. |
Sources/MGScopeBar/MGRecessedPopUpButtonCell.m |
Removes manual deallocation. |
Sources/MGScopeBar/MGRecessedPopUpButtonCell.h |
Adds the cell declaration. |
Sources/MGScopeBar/include/MGScopeBar.h |
Adds the public umbrella header. |
Sources/MGScopeBar/include/MGScopeBarDelegateProtocol.h |
Adds the public delegate protocol. |
Sources/MGScopeBar/Resources/Base.lproj/MainMenu.xib |
Adds the demo interface resource. |
Sources/MGScopeBar/Resources/en.lproj/InfoPlist.strings |
Adds localized resource metadata. |
Tests/MGScopeBarTests/MGScopeBarTests.swift |
Adds the package test target scaffold. |
README.md |
Documents usage, licensing, and platform support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hannesa2
force-pushed
the
SwiftPackageSupport
branch
from
September 21, 2026 06:00
abcd03c to
e81543f
Compare
Co-authored-by: hannesa2 <3314607+hannesa2@users.noreply.github.com>
hannesa2
force-pushed
the
SwiftPackageSupport
branch
from
September 21, 2026 08:41
3fd9c8f to
bc9b434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the last change from upstream