Conversation
Remove 3.9 from tox and tests, and update the "mindeps" build for 3.10, but make no other changes.
`requests==2.27.0` added support for python 3.10, so it is our new minimum now that we are on 3.10+
This was flagged after updating pinned deps. Passing iterable vs passing list(<iterable>).
- a pytest skip not caught by pyupgrade - an old python3.8 path was still available (under a TYPE_CHECKING guard) - `importlib_resources` for 3.8
With the recent update to the pinned mypy version, this needed adjustment.
This comment was marked as low quality.
This comment was marked as low quality.
kurtmckee
reviewed
Sep 23, 2026
Co-authored-by: Kurt McKee <39996+kurtmckee@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to dropping 3.9, this changeset does some cleanup of lingering items from the end of 3.8 support.
requestsand re-pin deps