Skip to content

Properly define byte vs string types in source and cache api boundaries #99

Description

@jaqx0r

While doing the python3 conversion I realised that the data handlers never cared about encodings and now we've got a mix of ascii and utf8 encodings between sources and caches. I'd like to formally state what types go where and enforce it.

For example, is nssdb a utf8 compatible cache? Or does it have to be ascii only? I think OpenLDAP, Samba4, etc allow utf8?

Should the Updater deal in Python str types and convert to bytes or deal with bytes only and avoid any encoding at all?

Once decided on, can pytype annotations force us to get conforming code?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions