Repository navigation
Conversation
ghost
closed this
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request completely removes the CMakeLists.txt build configuration file. The reviewer points out that the template file re2Config.cmake.in is now orphaned and should also be deleted from the repository to clean up unused files.
I am having trouble creating individual review comments. Click here to see my feedback.
CMakeLists.txt (266-268)
Since the CMake configuration (CMakeLists.txt) is being completely removed, the template file re2Config.cmake.in (referenced here) is no longer used and should also be deleted from the repository to prevent leaving orphaned/dead files.
/