Release pageheap_lock while releasing memory to the OS from HugePageFiller. - #1037
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…iller. Drop pageheap_lock around unback syscalls in HugePageFiller::ReleasePages (via UnbackSubreleaseFunction) and HugePageFiller::HandleFullyFreedTracker while preserving tracker invariants against concurrent allocations and deallocations: - Remove the PageTracker from regular_alloc_ / regular_alloc_partial_released_ before invoking ReleaseFree, temporarily pinning the subreleasing range in RangeTracker so concurrent TryGet calls skip it and concurrent Put calls cannot return the tracker as fully freed while unback is in flight. - Re-evaluate tracker state upon reacquiring pageheap_lock after ReleaseFree: if empty, defer whole-hugepage unback via StoreFullyFreedTracker for the caller to drain via HandleFullyFreedTracker; otherwise reinsert into the appropriate tracker list. - Stop multi-range ReleaseFree loops immediately if concurrent Put calls empty the tracker during an unlocked unback. - Update n_was_released_ and RecordLifetime before dropping pageheap_lock in HandleFullyFreedTracker so filler statistics remain consistent during unlocked unback. PiperOrigin-RevId: 982325222
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release pageheap_lock while releasing memory to the OS from HugePageFiller.
Drop pageheap_lock around unback syscalls in HugePageFiller::ReleasePages (via UnbackSubreleaseFunction) and HugePageFiller::HandleFullyFreedTracker while preserving tracker invariants against concurrent allocations and deallocations: