Skip to content

Release pageheap_lock while releasing memory to the OS from HugePageFiller. - #1037

Draft
copybara-service[bot] wants to merge 1 commit into
masterfrom
test_982325222
Draft

copybara-service[bot] wants to merge 1 commit into
masterfrom
test_982325222

Conversation

@copybara-service

Copy link
Copy Markdown

Release pageheap_lock while releasing memory to the OS from HugePageFiller.

Drop pageheap_lock around unback syscalls in HugePageFiller::ReleasePages (via UnbackSubreleaseFunction) and HugePageFiller::HandleFullyFreedTracker while preserving tracker invariants against concurrent allocations and deallocations:

  • Remove the PageTracker from regular_alloc_ / regular_alloc_partial_released_ before invoking ReleaseFree, temporarily pinning the subreleasing range in RangeTracker so concurrent TryGet calls skip it and concurrent Put calls cannot return the tracker as fully freed while unback is in flight.
  • Re-evaluate tracker state upon reacquiring pageheap_lock after ReleaseFree: if empty, defer whole-hugepage unback via StoreFullyFreedTracker for the caller to drain via HandleFullyFreedTracker; otherwise reinsert into the appropriate tracker list.
  • Stop multi-range ReleaseFree loops immediately if concurrent Put calls empty the tracker during an unlocked unback.
  • Update n_was_released_ and RecordLifetime before dropping pageheap_lock in HandleFullyFreedTracker so filler statistics remain consistent during unlocked unback.

…iller.

Drop pageheap_lock around unback syscalls in HugePageFiller::ReleasePages (via UnbackSubreleaseFunction) and HugePageFiller::HandleFullyFreedTracker while preserving tracker invariants against concurrent allocations and deallocations:
- Remove the PageTracker from regular_alloc_ / regular_alloc_partial_released_ before invoking ReleaseFree, temporarily pinning the subreleasing range in RangeTracker so concurrent TryGet calls skip it and concurrent Put calls cannot return the tracker as fully freed while unback is in flight.
- Re-evaluate tracker state upon reacquiring pageheap_lock after ReleaseFree: if empty, defer whole-hugepage unback via StoreFullyFreedTracker for the caller to drain via HandleFullyFreedTracker; otherwise reinsert into the appropriate tracker list.
- Stop multi-range ReleaseFree loops immediately if concurrent Put calls empty the tracker during an unlocked unback.
- Update n_was_released_ and RecordLifetime before dropping pageheap_lock in HandleFullyFreedTracker so filler statistics remain consistent during unlocked unback.

PiperOrigin-RevId: 982325222

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant