Reintroduce MADV_GUARD_INSTALL path for GWP-ASan. - #1053
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_985388750
branch
2 times, most recently
from
September 22, 2026 18:54
a2c8501 to
9471327
Compare
MADV_GUARD_INSTALL fails on mlock'd pages, so we fallback to mprotect for situations where the allocations may have been mlock'd or the process is running with mlockall. This is exercised by the test added in d32b4fa. We now fallback to mprotect when guarding is not possible on a particular slot and track how often the fallback path is used. PiperOrigin-RevId: 986170809
copybara-service
Bot
force-pushed
the
test_985388750
branch
from
September 22, 2026 19:46
9471327 to
0b395d0
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduce MADV_GUARD_INSTALL path for GWP-ASan.
MADV_GUARD_INSTALL fails on mlock'd pages, so we fallback to mprotect for situations where the allocations may have been mlock'd or the process is running with mlockall. This is exercised by the test added in d32b4fa.
We now fallback to mprotect when guarding is not possible on a particular slot and track how often the fallback path is used.