Synchronize background process actions disable in malloc_extension_test. - #1054
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
In `malloc_extension_test` (`21.6s` max duration in `-c dbg`, `8.34s` in `-c opt`): - `DynamicSlabMallocMetadata` (`5.03s`) instantiates `ScopedBackgroundProcessActionsEnabled background(false)`, which previously called `absl::SleepFor(absl::Seconds(5))` to wait for any active background thread iteration to complete. - `CpuCacheFlags` (`3.31s`) toggles CPU cache parameters across background thread iterations. Guard `MallocExtension_Internal_SetBackgroundProcessActionsEnabled` with the same mutex (`background_mutex`) held by `MallocExtension_Internal_ProcessBackgroundActions`, and replace `absl::SleepFor(sleep_time)` in the background loop with `background_mutex.AwaitWithTimeout(..., sleep_time)`. This guarantees that `SetBackgroundProcessActionsEnabled(false)` waits for any in-flight background action to complete and immediately wakes up any sleeping background thread without needing an arbitrary 5-second sleep in `ScopedBackgroundProcessActionsEnabled`. This reduces execution time across all unsharded `malloc_extension_test` variants from `21.6s` to `1.63s` in `-c dbg` (`0.72s` in `-c fastbuild`, `0.64s` in `-c opt`) with 0 flakes across 300 runs (`100/100` in `-c dbg`, `-c fastbuild`, and `-c opt` under `blase --configs=none`). PiperOrigin-RevId: 985542030
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize background process actions disable in malloc_extension_test.
In
malloc_extension_test(21.6smax duration in-c dbg,8.34sin-c opt):DynamicSlabMallocMetadata(5.03s) instantiatesScopedBackgroundProcessActionsEnabled background(false), which previously calledabsl::SleepFor(absl::Seconds(5))to wait for any active background thread iteration to complete.CpuCacheFlags(3.31s) toggles CPU cache parameters across background thread iterations.Guard
MallocExtension_Internal_SetBackgroundProcessActionsEnabledwith the same mutex (background_mutex) held byMallocExtension_Internal_ProcessBackgroundActions, and replaceabsl::SleepFor(sleep_time)in the background loop withbackground_mutex.AwaitWithTimeout(..., sleep_time). This guarantees thatSetBackgroundProcessActionsEnabled(false)waits for any in-flight background action to complete and immediately wakes up any sleeping background thread without needing an arbitrary 5-second sleep inScopedBackgroundProcessActionsEnabled.This reduces execution time across all unsharded
malloc_extension_testvariants from21.6sto1.63sin-c dbg(0.72sin-c fastbuild,0.64sin-c opt) with 0 flakes across 300 runs (100/100in-c dbg,-c fastbuild, and-c optunderblase --configs=none).