Conversation
Three of the release-reason lines in PageAllocInfo::Print had an extra literal "MiB" after the "(%6.1f MiB)" field, e.g.: ... (12.3 MiB) MiB released from ProcessBackgroundActions Remove the stray "MiB" so these lines match the format used by the "released in total" and "released from ReleaseMemoryToSystem" lines directly above them.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small text bug in
PageAllocInfo::Print(tcmalloc/stats.cc)where the format strings for
process_background_actions,soft_limit_exceeded, andhard_limit_exceededreleased-page countsprinted "MiB" twice, e.g.:
instead of the intended:
This is purely a cosmetic/diagnostic-output fix. The other two lines in the same function
("released in total" and "released from ReleaseMemoryToSystem")
were already correct and are unchanged.