Skip to content

Shrink sizes of per-size-class misses and overall cache misses from std::atomic<size_t> down to std::atomic<uint32_t>. #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Shrink sizes of per-size-class misses and overall cache misses from std::atomic<size_t> down to std::atomic<uint32_t>. #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tcmalloc/cpu_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,10 +528,10 @@ class CpuCache {
using Freelist = subtle::percpu::TcmallocSlab<kNumClasses>;

struct PerClassMissCounts {
std::atomic<size_t>
std::atomic<uint32_t>
misses[static_cast<size_t>(PerClassMissType::kNumTypes)];

std::atomic<size_t>& operator[](PerClassMissType type) {
std::atomic<uint32_t>& operator[](PerClassMissType type) {
return misses[static_cast<size_t>(type)];
}
};
Expand Down Expand Up @@ -588,9 +588,9 @@ class CpuCache {

// Helper type so we don't need to sprinkle `static_cast`s everywhere.
struct MissCounts {
std::atomic<size_t> misses[static_cast<size_t>(MissCount::kNumCounts)];
std::atomic<uint32_t> misses[static_cast<size_t>(MissCount::kNumCounts)];

std::atomic<size_t>& operator[](MissCount miss_count) {
std::atomic<uint32_t>& operator[](MissCount miss_count) {
return misses[static_cast<size_t>(miss_count)];
}
};
Expand Down
Loading