Repository navigation
Disable XML entity size limits when parsing watchface XML - #116
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the XML TransformerFactory to disable entity size limits (setting them to 0) to allow parsing watch faces with a large number of entity references, and adds a test verifying this behavior. However, disabling these limits introduces security risks, specifically making the parser vulnerable to XML Entity Expansion (Billion Laughs) and XXE attacks. It is recommended to disable DTDs entirely to mitigate these vulnerabilities while still allowing pre-defined entities.
JuliaSamartseva
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer JDK versions have a stricter limit on XML entity count, but watch face layouts can legitimately go past this limit.