Skip to content

feat: update API sources and regenerate - #9276

Closed
suztomo wants to merge 2 commits into
mainfrom
chore-update-libraries-2026-09-09
Closed

feat: update API sources and regenerate#9276
suztomo wants to merge 2 commits into
mainfrom
chore-update-libraries-2026-09-09

Conversation

@suztomo

@suztomo suztomo commented Sep 9, 2026

Copy link
Copy Markdown
Member

Update API sources and regenerate.

Included googleapis CLs

google/ads/admanager/v1

google/cloud/alloydb/v1alpha

google/cloud/alloydb/v1beta

google/cloud/chronicle/v1

google/cloud/compute/v1

google/cloud/compute/v1beta

google/cloud/geminidataanalytics/v1alpha

google/cloud/retail/v2alpha

google/cloud/vectorsearch/v1beta

google/cloud/visionai/v1

google/shopping/merchant/loyaltycustomers/v1

@suztomo
suztomo requested a review from a team as a code owner September 9, 2026 17:42
@github-actions
github-actions Bot requested a review from shivanee-p September 9, 2026 17:42

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the BreakTemplateService and adds CreateAudienceSegment and BatchCreateAudienceSegments RPCs to the AudienceSegmentService in the Google Ads Ad Manager v1 API. It also updates report definitions with payment profile and render rate fields, and regenerates the TypeScript/JavaScript client libraries, samples, and tests. As there are no review comments, I have no feedback to provide.

@suztomo

suztomo commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

"Presubmit / lint (pull_request)" failed:

  Installing dependencies in /home/runner/work/google-cloud-node/google-cloud-node/packages/google-shopping-merchant-reviews...
  Installing dependencies in /home/runner/work/google-cloud-node/google-cloud-node/packages/google-storagetransfer...
  Installing dependencies in /home/runner/work/google-cloud-node/google-cloud-node/packages/google-streetview-publish...
  Installing dependencies in /home/runner/work/google-cloud-node/google-cloud-node/packages/grafeas...
Error: Process completed with exit code 143.

I restarted the failed job.

@suztomo

suztomo commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

I restarted the failed job.

It failed again (without a meaningful error message).

@suztomo

suztomo commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Regenerate and verify clean git tree also failed. Checking.

@suztomo

suztomo commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Old google-gax in my local cache seems to have caused the generation-check failure in the previous commit (cl/978678041). Let's see the current check https://github.com/googleapis/google-cloud-node/actions/runs/34392693184/job/102604668827?pr=9276.

@suztomo

suztomo commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

"generation-check / Regenerate and verify clean git tree (pull_request)" succeeded.

@suztomo
suztomo marked this pull request as draft September 11, 2026 15:50
@suztomo

suztomo commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

Megan suspects real lint error. I'll recreate a pull request after clearing my cache folder.

@suztomo suztomo closed this Sep 11, 2026
@suztomo
suztomo deleted the chore-update-libraries-2026-09-09 branch September 11, 2026 18:09
@suztomo

suztomo commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

Done in #9293.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants