chore(gax): resolves linter warnings in gax - #9281
Draft
shivanee-p wants to merge 2 commits into
Draft
Conversation
shivanee-p
added this pull request to stack #9282
September 10, 2026 18:42
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several files in the @google-cloud/gax package, primarily focusing on formatting imports, type definitions, and converting unit tests in apiCallable.ts from callback-based (done) patterns to modern async/await syntax with assert.rejects. Feedback is provided regarding a skipped test in the unit tests, suggesting that an accompanying comment or TODO referencing a tracking issue should be added to explain the reason for skipping.
| }); | ||
|
|
||
| it.skip('retries with exponential backoff', done => { | ||
| it.skip('retries with exponential backoff', async () => { |
Contributor
There was a problem hiding this comment.
When skipping a test, please ensure there is an accompanying comment or TODO that references the correct tracking issue and accurately describes the failure reason.
References
- When skipping a test, ensure the accompanying comment or TODO references the correct tracking issue and accurately describes the failure reason.
shivanee-p
force-pushed
the
shivaneep-gax-linter-fixes
branch
from
September 11, 2026 18:08
7d14d55 to
087aea5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.