chore(generator): regenerate protos - #9286
Draft
feywind wants to merge 1 commit into
Draft
Conversation
Refreshes protos/protos.json and protos/index.js from the checked-in protos with the current protobufjs toolchain. This is generated-file churn only and is independent of the resumable upload work.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates protos.json in the GAPIC generator for TypeScript. It explicitly adds "edition": "proto2" to numerous descriptor and option definitions. Additionally, it updates option configurations by removing "packed": false options from certain fields (such as publicDependency, weakDependency, and targets) and adding "packed": true options to others (such as path and span). As there are no review comments, I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes protos/protos.json and protos/index.js from the checked-in protos with the current protobufjs toolchain. This is generated-file churn only and is independent of the resumable upload work.
Related to: #9283