chore(spanner): use nam6 instance config for test_create_instance_partition - #18271
Merged
sakthivelmanii merged 1 commit intoSep 3, 2026
Merged
Conversation
…tition
Cloud Spanner enforces DuplicatedBaseInstancePartitionConfigs ('Cannot create
an instance partition that shares a base config with another instance partition.').
Since snippets.create_instance_partition creates an instance partition in
nam3, update test_create_instance_partition in snippets_test.py to create
the parent instance in nam6 rather than nam3. This satisfies the multi-region
parent instance requirement while avoiding base config collision.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test_create_instance_partition test in snippets_test.py by removing the multi_region_instance_config fixture parameter and hardcoding the instance configuration path to use the nam6 multi-region configuration. There are no review comments, and I have no additional feedback to provide.
sakthivelmanii
enabled auto-merge (squash)
September 3, 2026 05:40
rahul2393
approved these changes
Sep 3, 2026
sakthivelmanii
deleted the
fix-spanner-instance-partition-config-collision
branch
September 3, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Spanner enforces DuplicatedBaseInstancePartitionConfigs ('Cannot create an instance partition that shares a base config with another instance partition.').
Since snippets.create_instance_partition creates an instance partition in nam3, update test_create_instance_partition in snippets_test.py to create the parent instance in nam6 rather than nam3. This satisfies the multi-region parent instance requirement while avoiding base config collision.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕