Skip to content

chore(spanner): use nam6 instance config for test_create_instance_partition - #18271

Merged
sakthivelmanii merged 1 commit into
mainfrom
fix-spanner-instance-partition-config-collision
Sep 3, 2026
Merged

chore(spanner): use nam6 instance config for test_create_instance_partition#18271
sakthivelmanii merged 1 commit into
mainfrom
fix-spanner-instance-partition-config-collision

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Cloud Spanner enforces DuplicatedBaseInstancePartitionConfigs ('Cannot create an instance partition that shares a base config with another instance partition.').

Since snippets.create_instance_partition creates an instance partition in nam3, update test_create_instance_partition in snippets_test.py to create the parent instance in nam6 rather than nam3. This satisfies the multi-region parent instance requirement while avoiding base config collision.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…tition

Cloud Spanner enforces DuplicatedBaseInstancePartitionConfigs ('Cannot create
an instance partition that shares a base config with another instance partition.').

Since snippets.create_instance_partition creates an instance partition in
nam3, update test_create_instance_partition in snippets_test.py to create
the parent instance in nam6 rather than nam3. This satisfies the multi-region
parent instance requirement while avoiding base config collision.
@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner September 3, 2026 05:36

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test_create_instance_partition test in snippets_test.py by removing the multi_region_instance_config fixture parameter and hardcoding the instance configuration path to use the nam6 multi-region configuration. There are no review comments, and I have no additional feedback to provide.

@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) September 3, 2026 05:40
@sakthivelmanii
sakthivelmanii merged commit 2d8093e into main Sep 3, 2026
46 checks passed
@sakthivelmanii
sakthivelmanii deleted the fix-spanner-instance-partition-config-collision branch September 3, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants