all: bump golang.org/x/tools and other dependencies - #268
Open
thomasjm wants to merge 1 commit into
Open
Conversation
The vendored golang.org/x/tools v0.14.0 uses unsafe struct-layout hacks in internal/tokeninternal that are incompatible with Go 1.26+. That package was removed entirely in newer x/tools versions. Bump to golang.org/x/tools v0.45.0 and update all transitive dependencies accordingly. Set godebug gotypesalias=0 because gomacro does not support *types.Alias.
Author
|
Hi @cosmos72, any chance I could get your attention here? Thanks! |
Member
|
Hi @thomasjm, I've recently updated gomacro with initial support for |
13 tasks
thomasjm
added a commit
to codedownio/nixpkgs
that referenced
this pull request
Sep 1, 2026
The pinned gomacro predates Go generics, so the kernel panicked with "Converter.Type(): unsupported types.Type: *types.TypeParam" on startup and the package failed to build. Upstream has not tagged since 0.7.5 and master carries several interpreter fixes, so move to master and apply the open dependency bump from gopherdata/gophernotes#268 on top.
Member
|
I've created pull request #270 as a replacement for this pull request. Any objection about sticking to go toolchain 1.23.0, and to slightly older dependencies? |
Author
|
Looks fine to me, I verified it builds against current Nixpkgs Go 1.26. |
nixos-cuda-channel-updater Bot
pushed a commit
to nixos-cuda/nixpkgs
that referenced
this pull request
Sep 2, 2026
The pinned gomacro predates Go generics, so the kernel panicked with "Converter.Type(): unsupported types.Type: *types.TypeParam" on startup and the package failed to build. Upstream has not tagged since 0.7.5 and master carries several interpreter fixes, so move to master and apply the open dependency bump from gopherdata/gophernotes#268 on top. (cherry picked from commit ed6f54a)
onny
pushed a commit
to onny/nixpkgs
that referenced
this pull request
Sep 2, 2026
The pinned gomacro predates Go generics, so the kernel panicked with "Converter.Type(): unsupported types.Type: *types.TypeParam" on startup and the package failed to build. Upstream has not tagged since 0.7.5 and master carries several interpreter fixes, so move to master and apply the open dependency bump from gopherdata/gophernotes#268 on top. (cherry picked from commit ed6f54a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored golang.org/x/tools v0.14.0 uses unsafe struct-layout hacks in internal/tokeninternal that are incompatible with Go 1.26+. That package was removed entirely in newer x/tools versions.
Bump to golang.org/x/tools v0.45.0 and update all transitive dependencies accordingly. Set godebug gotypesalias=0 because gomacro does not support *types.Alias.