[makhnatkin]

Attachment form submission

• Added regression coverage for file and image submission after input composition.
• Updated text fields to submit on Enter keydown.
• Prevented Enter from submitting during input composition.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="packages/editor/src/utils/handlers.ts" line_range="7" />
<code_context>
 ): React.KeyboardEventHandler<T> {
     return (event) => {
-        if (event.key === Key.Enter) {
+        if (event.key === Key.Enter && !event.nativeEvent.isComposing) {
             handler(event);
         }
</code_context>
<issue_to_address>
**Form submits during IME composition**

When a browser reports `isComposing` as false on the Enter keydown that confirms composition, `enterKeyHandler` calls the submit handler for that Enter keydown, so the form submits before the composed text is finished.

Also treat `keyCode === 229` as composition input and skip calling the handler for that Enter keydown.

Also at `packages/editor/src/forms/FileForm.tsx:111`, `packages/editor/src/forms/ImageForm.tsx:121`.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[gravity-ui]

[gravity-ui]