Skip to content

Remove css loader to use Webpack native - #17018

Draft
zaraGNM wants to merge 3 commits into
mainfrom
zk-migrate-css-loader
Draft

zaraGNM wants to merge 3 commits into
mainfrom
zk-migrate-css-loader

Conversation

@zaraGNM

@zaraGNM zaraGNM commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

This Pr removes css loader and to-string-loader to use Webpack's native CSS handling.

Why?

css-loader is now depreciated and webpack suggest using native css handling.

How has this change been tested?

Tested locally and in CODE

@zaraGNM zaraGNM added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:ad18630f815954b884421cebaab205e2f50023a5d8b9c79203949167b8e03cde

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:ad18630f815954b884421cebaab205e2f50023a5d8b9c79203949167b8e03cde"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-zk-migrate-css-loader"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-33057"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant