Repository navigation
add signed url support - #21
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Signed mode breaks picture sources and can generate invalid signatures in CSS or JavaScript contexts.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Adds experimental Gumlet signed URL support with optional expiry and disables client-side resizing when enabled.
Changes:
- Adds URL signing and server-side image rewriting.
- Adds configuration controls, warnings, and documentation.
- Bumps the plugin version to 1.4.5.
| File | Description |
|---|---|
README.md |
Documents signed URL setup and behavior. |
readme.txt |
Updates features, FAQ, and release notes. |
changelog.txt |
Adds the 1.4.5 changelog. |
gumlet.php |
Bumps version and loads signing helpers. |
includes/options-page.php |
Adds signed URL settings and warnings. |
includes/gumlet-sign-url.php |
Implements signature and query helpers. |
includes/class-gumlet.php |
Integrates signing into image rewriting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+251
to
+252
| if (!empty($this->options['signed_urls'])) { | ||
| return false; |
Comment on lines
+382
to
+387
| $query = parse_url($raw, PHP_URL_QUERY); | ||
| if (is_string($query) && preg_match('/(?:^|&)s=/', $query)) { | ||
| return $match[0]; | ||
| } | ||
|
|
||
| $signed = $this->replace_image_url($raw); |
| return $match[0]; | ||
| } | ||
|
|
||
| return str_replace('&', '&', $signed); |
Contributor
Author
|
@copilot review again |
Review found one issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.