Address unsupported operand type(s): 'decimal.Decimal' and 'float' - #47
Open
rafaelweingartner wants to merge 1 commit into
Open
rafaelweingartner wants to merge 1 commit into
rafaelweingartner wants to merge 1 commit into
Conversation
This patch address situation around mixed type operations. For instance,
the following expression, "(1 + 3 + 2.0 + 6) * 0.00001", when evaluated,
causes the following error:
```
>>> from mathparse import mathparse
>>> mathparse.parse("(1 + 3 + 2.0 + 6) * 0.00001")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/rafael/git/mathparse/mathparse/mathparse.py", line 792, in
parse
tokens = tokenize(string, language)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rafael/git/mathparse/mathparse/mathparse.py", line 570, in
evaluate_postfix
total = to_number(a) + to_number(b)
~~~~~~~~~~~~~^~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for *: 'decimal.Decimal' and
'float'
```
This patch normalizes the "to_number" operation, to always return
Decimal objects. Therefore, the error will not occur, by mixing Number
types.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch address a situation around mixed type operations. For instance, the following expression, "(1 + 3 + 2.0 + 6) * 0.00001", when evaluated, causes the following error:
This patch normalizes the "to_number" operation, to always return Decimal objects. Therefore, the error will not occur, by mixing Number types.