[harleypig]

Summary

Language servers, prose linting and Markdown linting in the editor, plus two
inert items from #44. One commit per issue:

• Remove language-server blocks in coc-settings.json that a CoC extension already provides #21: languageserver.dockerfile is removed. coc-docker already
  starts the same server from its own bundled copy, so it was running twice.
  A live CoC session on master lists both languageserver.dockerfile and
  docker as running; on this branch only docker runs.
  languageserver.terraform stays, with a comment: no CoC extension bundles
  terraform-ls (the one published coc-terraform starts the same external
  binary).
• The HTML language server in coc-settings never starts or attaches #133: languageserver.html never started. It ran
  vscode-html-languageservice, an npm library with no executable, for
  filetype mustache, while vim-polyglot sets html.mustache. The block is
  removed in favour of coc-html, which bundles the same service. That is
  the Remove language-server blocks in coc-settings.json that a CoC extension already provides #21 case. html.filetypes keeps coc-html's defaults and adds
  html.mustache. docs/html.md now describes coc-html.
• CoC's proselint diagnostics never run: missing config file and old command line #132: proselint 0.16.0, the current release, takes a subcommand, so
  proselint --config … - failed with invalid choice: '-'. The config
  file it named has not existed since 2023. CoC now runs proselint check,
  which reads stdin, and proselint finds its own config. The existing
  formatPattern matches 0.16's output, and the columns are 1-based, as
  diagnostic-languageserver expects. docs/proselint.md is updated,
  including the Language pages credit ale.vim with ftplugin settings, and miss configured linters #104 items for that page.
• In-editor Markdown fixer and linter may disagree with .markdownlint.yaml #51: prettier was ALE's Markdown fixer on save. It rewrites *
  bullets to - and has no option to keep * (checked with prettier
  3.9.6), so it is dropped and Markdown gets only the global fixers.
  markdownlint-cli reads .markdownlint.yaml only from its working
  directory, and ALE runs it from Vim's. A new after/ftplugin/markdown.vim
  passes the nearest config file above the buffer with --config.
• Small tidy-ups: envsubstitute help quote, old shell-lint warnings, proselint config path #44 (two items): the ALEVirtualText* highlights in
  diagnostic-colors.vim are removed, because ALE's virtual text is off
  (g:ale_virtualtext_cursor = 'disabled'). .eslintrc.json is removed,
  because nothing runs ESLint: ALE lints only the filetypes it is given, and
  coc-eslint is gone.

Closes #21
Refs #133
Closes #132
Closes #51
Closes #104
Refs #44

#133 stays open (Refs) until a sibling pull request this round adds
coc-html to g:coc_global_extensions in .vimrc. Until then HTML has no
language server, but it had no working one before either.

#104 is closed here because this PR carries its last item, the
docs/proselint.md lines. The rest of #104 landed in #140.

Decisions (operator's standing rule: remove, make work, or keep with a note)

Item	Choice	Why
languageserver.dockerfile	Removed	coc-docker starts the same server
languageserver.terraform	Kept, with a note	No extension bundles terraform-ls
languageserver.html	Removed; coc-html instead	The block could not start; coc-html bundles the server and follows #21
proselint in CoC	Made to work	proselint 0.16 check on stdin, no dead --config
prettier Markdown fixer	Removed	Breaks MD004; it has no option to keep *
markdownlint config	Made to work	--config to the nearest file, set per buffer
ALEVirtualText* highlights	Removed	Virtual text is deliberately off
.eslintrc.json	Removed	No linter or extension reads it

Sources

• proselint 0.16.0: proselint --help and proselint check --help from
  the PyPI release, run in a scratch venv; config search order from the
  project README (## Configuring).
• Prettier: docs/options.md lists no list-marker option.
• markdownlint-cli README, ## Configuration: the .markdownlint.* file
  is read from "the current folder".
• coc-html 1.9.2 package.json: html.filetypes and its default.
• coc.nvim doc/coc.txt coc-document-filetype: only a few filetypes are
  remapped; others go through as they are.

Changes needed outside this PR

• .vimrc: add 'coc-html' to g:coc_global_extensions (sibling PR).
• bin/post-clone: the dockerfile-language-server-nodejs install (line
  37) and the prettier install (line 39) are no longer used (sibling PR).
• ALE submodule: the pinned ALE (80ff84db) runs proselint %t for
  Markdown, which proselint 0.16 rejects. Upstream fixed it in d59cb7b3
  (fix-proselint, fix-proselint dense-analysis/ale#5074). docs/proselint.md says so.

After #140 merges

Apply these on rebase, before this PR merges:

1. docs/editor-settings.md, the diagnostic-colors table: drop
   ALEVirtualTextError, ALEVirtualTextWarning and ALEVirtualTextInfo
   from the Groups column, and drop them from the sentence "The Coc*Sign
   and ALEVirtualText* groups are set but do not show". Any line range
   cited for diagnostic-colors.vim shrinks by 16 lines (71-86 are gone).
2. docs/docker.md: the Dockerfile language server is started by
   coc-docker from its own bundled copy, not by a block in
   coc-settings.json. Credit coc-docker, and stop pointing the
   language-server configuration at coc-settings.json. The External
   Packages entry for dockerfile-language-server-nodejs goes once
   post-clone stops installing it.

Test plan

• bats tests/vim: 56 ok, 0 failed.
• bats tests/shell: all ok.
• markdownlint docs/html.md docs/proselint.md: clean.

Testing evaluation

Run by the author to the qa-tester's standard; this repository declares no
team-managed: sentinel.

1. Verdict: needs tests, written in this PR as the new
   tests/vim/intellisense.bats (7 tests), plus one changed line in
   tests/vim/load.bats.
2. Automatable: yes. bats in headless Vim, per .claude/TESTS.md. The
   coc-settings tests decode coc-settings.json after dropping its
   whole-line comments; a file that will not decode fails.
3. Falsifiers, each seen red against master and green on this branch
   (test 6 is the over-match guard and is green on both by design):
   • Languageserver keys: red while dockerfile or html is present.
   • html.filetypes: red without html.mustache, or with the key absent.
   • proselint args: red on anything but ["check"].
   • Markdown fixers: red while g:ale_fixers.markdown exists.
   • markdownlint, nearest config: red when a buffer below a
     .markdownlint.yaml, opened from another cwd, gets no --config.
   • markdownlint, no config: red if the ftplugin sets the option where no
     config file exists.
   • Virtual text: red while our file gives ALEVirtualText* a background.
4. Disposition: written in this PR.
5. Entry-point reach: n/a. Nothing here is a guard, gate or refusal
   path.

Manual verification

1. Where: a terminal, in this checkout.
2. What to do and what success looks like:
   • a. Open a Dockerfile in Vim with CoC running, wait for CoC to start,
     and run :echo map(CocAction('services'), 'v:val.id . ":" . v:val.state').
     Success: docker:running and no languageserver.dockerfile entry.
   • b. Open a doc in this repository from another directory
     (cd /tmp && vim ~/projects/dotvim/docs/x.md) and run
     :echo b:ale_markdown_markdownlint_options. Success: --config '…/dotvim/.markdownlint.yaml'. Put a - dash bullet in the file and
     save. Success: ALE reports MD004 "Expected: asterisk; Actual: dash",
     and the bullet is not rewritten.
   • c. Pipe text to the CoC proselint command: printf 'This is very unique.\n' | proselint check. Success: <stdin>:1:9: uncomparables: ….
   • d. With coc-html installed, open a .mustache file and check
     CocAction('services') lists the HTML server running.
3. Failure looks like: in (a), languageserver.dockerfile listed again;
   in (b), no MD004 report, or the dash rewritten on save; in (c), invalid choice.
4. What happened:
   • a. Run in a live Vim with CoC (node present, the worktree's
     coc-settings.json): services=["languageserver.terraform:init", "diagnostic-languageserver:init","docker:running"]. The same Vim on
     master's settings listed languageserver.dockerfile:running and
     docker:running together.
   • b. Ran the exact command ALE built for a buffer in docs/, from a
     scratch directory: 'markdownlint' --config '…/.markdownlint.yaml' %s.
     With the option it reported MD004/ul-style … [Expected: asterisk; Actual: dash], exit 1. Without it, from the same directory, nothing,
     exit 0.
   • c. proselint 0.16.0 in a scratch venv: <stdin>:1:9: uncomparables: …,
     exit 1 (findings). The old command line gave invalid choice: '-',
     exit 2.
   • d. Not run. coc-html is not installed on this host. A packed copy
     loaded from a scratch CoC data directory failed to start without its
     npm dependencies, and installing them was declined in this
     environment. To run it: coc-html installed through .vimrc's list
     (sibling PR), then step d as written.

Review

code-review-style self-review of the full diff. It found no defects.
Observations:

• after/ftplugin/markdown.vim calls ALE's autoload functions. ALE is a
  start package that loads with or without Node (tests/vim/coc.bats), so
  they are always available.
• The "no config" test assumes no .markdownlint.* in any directory above
  the test's temp directory. That holds on CI and on this host.
• The late ale.vim still sets the Markdown linters globally under a
  "TODO: Move to ftplugin/markdown.vim". Moving them is out of scope here.

Completion report

1. The functionality works: met. See Manual verification; step d is
   pending coc-html (sibling PR) and The HTML language server in coc-settings never starts or attaches #133 stays open on it.
2. The access model is defined: not applicable. Editor configuration
   with no access surface.
3. Permissions are implemented: not applicable, for the same reason.
4. Audit logging is implemented: not applicable, for the same reason.
5. Validation is complete: not applicable. No input is taken.
6. Errors are handled: met. With no config file the ftplugin leaves
   markdownlint's options alone (test 6).
7. Testing is complete: met. See Testing evaluation.
8. Documentation exists: met for docs/html.md and docs/proselint.md.
   docs/docker.md and docs/editor-settings.md are updated after docs: editor settings page, statusline row, language-page drift (#109, #102, #104) #140,
   as described above.
9. The AI Completion Report has been produced: this section.

Co-Authored-By: AI Agent noreply@harleypig.com