fix(app): drop the confirmation on engine toggle-off (#1598)

[jeonghun-jj-lee]

Removes the "there are in-flight turns. Stop anyway?" prompt that popped on essentially every engine toggle-off.

Why it was broken

The guard's predicate was sseState === "live" — but "live" is the ordinary healthy stream state (opencode emits periodic ping frames that keep it live; it only degrades to "stale" after 30s of total silence). So the warning fired even when completely idle. It was also asymmetric: toggle-off prompted, toggle-on (Restart) never did.

What I verified first (subagent trace of the full chain)

The kill/respawn logic itself is correct — the prompt was the only defect:

• Toggle OFF fully kills the process: amicode.stopServer → ServerManager.stop() sends SIGTERM, polls ≤3s, escalates to SIGKILL, then frees the port via an lsof probe. It reaches the detached/adopted engine too (kills by the handshake-recorded PID, not just a session-spawned child). Fleet self-shutdown is an engine-side idle timer and never intercepts the signal.
• Toggle ON spawns a genuinely new process: amicode.restartServer awaits stop() then cold-spawns a fresh detached opencode serve (new PID) — never adopts a stale one; stop→start is sequential, so no port-collision race.

Changes

• stop_server.ts — remove the in-flight-turns guard and its now-unused hasInFlightTurns/showWarning deps. stopServer is now stop() → deleteHandshake(), no confirmation.
• extension.ts — drop the hasInFlightTurns/showWarning wiring.
• stop_server.test.ts — assert the no-confirmation contract, the kill-before-delete ordering, and that a stop() rejection does not clear the handshake.

Scope note

The Quit command (quit_command.ts) has the identical broken predicate, but Quit closes the whole window — a more destructive action where a guard is more defensible. Left untouched here; flagging for a separate decision (remove vs. fix the predicate).

Testing

• 297 test files pass (5018 tests); stop_server 3/3
• Extension typecheck clean
• Pure extension change — no app-bundle/binary rebuild required; just a pnpm -r build + window reload.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bdab6489-02d4-4b1b-89bb-30e523e3f6c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}