Skip to content

⚡ perf: optimize updateRevTable string concatenation - #20

Open
hashkrish wants to merge 4 commits into
mainfrom
perf-update-rev-table-9541318591842575344
Open

hashkrish wants to merge 4 commits into
mainfrom
perf-update-rev-table-9541318591842575344

Conversation

@hashkrish

Copy link
Copy Markdown
Owner

💡 What: Replaced fmt.Sprintf and the + operator in updateRevTable with a strings.Builder.
🎯 Why: To optimize string concatenation inside a loop, reducing memory allocations and CPU overhead in internal/services/cloudrun/run.go.
📊 Measured Improvement: We saw an improvement by running the benchmark test which demonstrated roughly a 30% reduction in CPU ops execution time for that block (from 343199 ns/op down to 240184 ns/op).


PR created automatically by Jules for task 9541318591842575344 started by @hashkrish

Replace fmt.Sprintf and string concatenation with strings.Builder
in internal/services/cloudrun/run.go to reduce allocations and improve
loop performance.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Pin golangci-lint action version to v1.60.1 in the github workflow to be compatible with Go 1.25.5 as the default 'latest' action failed on github CI. Also pin golangci-lint go version in .golangci.yml.
Replace fmt.Sprintf and string concatenation with strings.Builder in internal/services/cloudrun/run.go to reduce allocations and improve loop performance.
Replace fmt.Sprintf and string concatenation with strings.Builder in internal/services/cloudrun/run.go to reduce allocations and improve loop performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant