Repository navigation
Fix CI lint: upgrade to golangci-lint v2 - #56
Merged
Merged
Conversation
golangci-lint-action@v6 with version: latest installed golangci-lint v1.64.8, built with go1.24, which refuses to lint a go 1.25.5 module and cannot read the v2 config. Pin golangci-lint-action@v9 to golangci-lint v2.14.0, restore version: "2" in .golangci.yml (reverting 656e268's go: '1.24' workaround), and fix the two issues the working linter reports (unchecked Close in cloudbuild, unnecessary conversion in artifactregistry).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint-action@v6 with version: latest installed golangci-lint
v1.64.8, built with go1.24, which refuses to lint a go 1.25.5 module
and cannot read the v2 config. Pin golangci-lint-action@v9 to
golangci-lint v2.14.0, restore version: "2" in .golangci.yml (reverting
656e268's go: '1.24' workaround), and fix the two issues the working
linter reports (unchecked Close in cloudbuild, unnecessary conversion
in artifactregistry).