Repository navigation
Conversation
The package sub-resources for upload-time and uploader used to incorrectly refer to the latest revision and Hackage admin who performed the revision, this is now fixed so that `/uploader` and `/upload-time` now reference the original author that uploaded the package and the time at wich the package was actually uploaded originally. Fixes: haskell#1145
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Member
|
How did you test this? |
Member
|
I think this needs more discussion, and some concrete acceptance criteria. Since these patch-up endpoints are for the mirroring, and they are supposed to match their setters, it wouldn't be intuitive after merging this. A mirror client would be calling those endpoints to decide whether the uploader-time/uploader is in sync, and then it would fetch the state first revision, which is not necessarily the one the setters would be overriding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package sub-resources for upload-time and uploader used to
incorrectly refer to the latest revision and Hackage admin who performed
the revision, this is now fixed so that
/uploaderand/upload-timenow reference the original author that uploaded the package and the time
at wich the package was actually uploaded originally.
Fixes: #1145