Repository navigation
Type what PHP's array functions return - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP's signatures for
array_filter(),array_merge(),reset()and similar functions only sayarrayormixed, so a call on their result had no known type. The type now comes from the argument: an array of its elements, the elements of every argument forarray_merge/array_replace(AMBIGUOUS if one argument's elements are unknown), or a single element forreset,end,array_shift… A project function with the same name still wins.Corpus, application code (unknown receivers / INFERRED call sites): Sylius −2 / 0, Akeneo −2 / +3, PrestaShop −4 / +5, WordPress −2 / +5. Edge diff: Sylius drops 2 wrong AMBIGUOUS guesses, PrestaShop gains 5 correct edges, and no INFERRED edges are lost. Baseline updated.
Also on this branch: typing a global variable by its
@globaltag, and the MIT license with the French README brought in line with the English one.