Skip to content

refactor: drop dead _BUILD_ARG_ fallbacks from option variable reads - #89

Merged
baxyz merged 1 commit into
mainfrom
unify-option-var-format
Sep 8, 2026
Merged

baxyz merged 1 commit into
mainfrom
unify-option-var-format

Conversation

@baxyz

@baxyz baxyz commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • claude-dev, mistral-dev, cline-dev, copilot-dev, github-dev, and dotfiles-sync each read their feature options as "${_BUILD_ARG_X:-${X:-default}}" instead of the plain "${X:-default}" every other feature in this repo already uses.
  • That prefix is only ever set by the devcontainers CLI for the legacy internalVersion: "1" manifest shape (confirmed via nub's own install.sh comment, and confirmed no feature in this repo declares that field) — so the _BUILD_ARG_ branch never fires and always falls through to the plain env var anyway.
  • Pure dead code removal, not a behavior change: verified the old and new forms resolve identically for both a set and an unset env var.
  • cline-dev and copilot-dev had no ## Version History section at all — added one alongside this change.

Board card: "Unify feature option variable format (legacy BUILD_ARG* vs modern no-prefix)" (Backlog, Medium priority).

Test plan

  • bash -n syntax checks, JSON validated on all 6 features
  • Confirmed zero remaining _BUILD_ARG_ usages outside of nub's explanatory comment
  • Confirmed old vs. new form resolve identically (set and unset cases)
  • CI

🤖 Generated with Claude Code

claude-dev, mistral-dev, cline-dev, copilot-dev, github-dev, and
dotfiles-sync each read their feature options as
"${_BUILD_ARG_X:-${X:-default}}" instead of the plain "${X:-default}" every
other feature in this repo already uses. That prefix is only ever set by the
devcontainers CLI for the legacy internalVersion: "1" manifest shape (per
nub's own install.sh comment, added when it was written the modern way) —
confirmed no feature here declares that field, so the _BUILD_ARG_ branch
never fires and always falls through to the plain env var anyway. Pure dead
code, not a behavior change: verified the old and new forms resolve
identically for both a set and an unset env var.

cline-dev and copilot-dev had no Version History section at all — added one
alongside this change instead of leaving it out for just these two.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

✅ PR Validation Passed

All checks passed!


📋 Pipeline Status

Job Status
🧾 Conventional Commits passing
🔖 Version Bump passing
🧪 Feature Tests passing
🐚 ShellCheck passing

🤖 Generated by @helpers4 CI • 2026-09-08

@baxyz
baxyz merged commit 1857b93 into main Sep 8, 2026
40 checks passed
@baxyz
baxyz deleted the unify-option-var-format branch September 8, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant