refactor: drop dead _BUILD_ARG_ fallbacks from option variable reads - #89
Merged
Merged
Conversation
claude-dev, mistral-dev, cline-dev, copilot-dev, github-dev, and
dotfiles-sync each read their feature options as
"${_BUILD_ARG_X:-${X:-default}}" instead of the plain "${X:-default}" every
other feature in this repo already uses. That prefix is only ever set by the
devcontainers CLI for the legacy internalVersion: "1" manifest shape (per
nub's own install.sh comment, added when it was written the modern way) —
confirmed no feature here declares that field, so the _BUILD_ARG_ branch
never fires and always falls through to the plain env var anyway. Pure dead
code, not a behavior change: verified the old and new forms resolve
identically for both a set and an unset env var.
cline-dev and copilot-dev had no Version History section at all — added one
alongside this change instead of leaving it out for just these two.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-09-08 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-dev,mistral-dev,cline-dev,copilot-dev,github-dev, anddotfiles-synceach read their feature options as"${_BUILD_ARG_X:-${X:-default}}"instead of the plain"${X:-default}"every other feature in this repo already uses.internalVersion: "1"manifest shape (confirmed vianub's own install.sh comment, and confirmed no feature in this repo declares that field) — so the_BUILD_ARG_branch never fires and always falls through to the plain env var anyway.cline-devandcopilot-devhad no## Version Historysection at all — added one alongside this change.Board card: "Unify feature option variable format (legacy BUILD_ARG* vs modern no-prefix)" (Backlog, Medium priority).
Test plan
bash -nsyntax checks, JSON validated on all 6 features_BUILD_ARG_usages outside ofnub's explanatory comment🤖 Generated with Claude Code