refactor: dedupe arch/latest-release logic into helpers4-common (git-absorb, bitwarden-secrets-manager) - #96
Merged
Conversation
…_github_latest_tag Drops the inline architecture-detection and latest-release-resolution logic in favor of the shared helpers added in helpers4-common (PR #95), which this feature already depends on. No behavior change — verified directly in a container: git-absorb still resolves and installs the latest release correctly through the new code path. Needs helpers4-common's h4-common-arch-helpers PR merged and republished first — dependsOn resolves from GHCR, not this repo's local src/ tree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…arch/latest-release helpers Drops the inline architecture-detection and latest-release-resolution logic (including its own bws- prefix filtering for the sdk-sm monorepo) in favor of the shared helpers added in helpers4-common (PR #95), which this feature already depends on. No behavior change — verified directly in a container: bws still resolves and installs the latest release correctly through the new code path. Needs helpers4-common's h4-common-arch-helpers PR merged and republished first — dependsOn resolves from GHCR, not this repo's local src/ tree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ecrets-manager Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-09-09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helpers4-common'sh4_arch_musl_triple/h4_github_latest_tag(added in feat(helpers4-common): add h4_arch_musl_triple and h4_github_latest_tag #95, merged) instead of carrying inline copies.Needs
helpers4-common's new helpers (#95) to be merged and republished to GHCR first, sincedependsOnresolves from the published registry — that's already the case now.Test plan
git-absorb 0.9.0andbws 2.1.0both install correctly through the refactored code path