Skip to content

docs: add headers and review - #1478

Merged
lukasmetzner merged 2 commits into
mainfrom
cli-add-headers
Sep 7, 2026
Merged

docs: add headers and review#1478
lukasmetzner merged 2 commits into
mainfrom
cli-add-headers

Conversation

@svenja11

@svenja11 svenja11 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@svenja11
svenja11 requested a review from a team as a code owner September 4, 2026 09:58
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.08%. Comparing base (5b68ce0) to head (a5bdaa3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files         301      301           
  Lines       11097    11097           
=======================================
  Hits         8110     8110           
  Misses       2090     2090           
  Partials      897      897           
Flag Coverage Δ
e2e 51.46% <ø> (ø)
unit 67.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmetzner lukasmetzner changed the title Add headers docs: add headers and review Sep 7, 2026
@lukasmetzner
lukasmetzner merged commit bd387d5 into main Sep 7, 2026
9 checks passed
@lukasmetzner
lukasmetzner deleted the cli-add-headers branch September 7, 2026 08:00

<br>

1. Install the hcloud CLI

@jooola jooola Sep 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for breaking the sections with titles into a numbered list and adding the many html elements?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the formatting we use in the docs (see Using S3 compatible CLI tools, for example). I updated it like this so that the formatting is consistent. We usually use <details> when there are a lot of options, because it helps readers see all options at a glance, and makes the content easier to navigate in the docs.

@jooola jooola Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to find a middle ground between the format we had, and the one in the docs? Because now the tutorial does not look great on Github:

Before: https://github.com/hetznercloud/cli/blob/5b68ce0ae339987d6f42cd9a7cb9533be6354fb1/docs/tutorials/setup-hcloud-cli.md
After: https://github.com/hetznercloud/cli/blob/bd387d58bfdfeafb7003733f7e2dcac1913d9454/docs/tutorials/setup-hcloud-cli.md

In Github, having titles for the sections automatically generates a "Table of content" for the users:

Image

I feel like the markdown document is not the right place for fixing styling issues (e.g. adding <br> to have more space between paragraphs), could we maybe fix this in the docs code directly?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it for a bit but I can't really think of a good in-between. If this formatting is causing issues on GitHub, I guess we can go back to the original formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants