Restore undo and redo in Godley popups by Copilot · Pull Request #1018 · highperformancecoder/minsky

Copilot · 2026-10-18T22:16:19Z

Godley popup edits were not consistently recorded in the popup’s table history, leaving Undo and Redo ineffective in JavaScript and Tcl/Tk interfaces.

History: Capture edits from cell changes, keyboard and mouse input, clipboard actions, and row or column operations. Preserve redo states until a new edit branches history.
Popup refresh: Update the restored table and refresh the JavaScript popup after Undo or Redo.

godley.popup.addFlowByRow(row)
godley.popup.undo(1)   # undo
godley.popup.undo(-1)  # redo

Fixes [SF#1366] undo/redo not working in Godley popup #804

This change is

coderabbitai · 2026-10-18T22:16:27Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: c380c4cf-381c-4dd9-9f6f-6b4eabdfa456

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

highperformancecoder · 2026-10-20T00:32:45Z

@copilot undo works, but not redo.

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

Copilot · 2026-10-20T00:38:06Z

@copilot undo works, but not redo.

Fixed in 4268541: table refresh after undo could normalize blank initial-condition cells and invalidate the redo snapshot. The restored snapshot is now preserved exactly, with regression coverage added.

highperformancecoder · 2026-10-20T01:30:31Z

@CodeRabbit review

coderabbitai · 2026-10-20T01:30:38Z

⚠️ Action not completed

Review skipped.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

highperformancecoder · 2026-10-20T01:34:13Z

@CodeRabbit rereview

coderabbitai · 2026-10-20T01:34:28Z

@highperformancecoder I’ll trigger a full re-review of all changes, with particular attention to redo behavior in Godley popups.

⚠️ Action not completed

Review skipped.

Copilot

🟡 Changes recommended

Unresolved undo correctness issues can lose edits, restore inconsistent state, and invalidate redo history.

5 open issues

What changed in this PR

Restores Godley popup Undo/Redo for JavaScript and Tcl/Tk interfaces, addressing #804.

Changes:

Records cell, clipboard, mouse, keyboard, and structural edits in popup history.
Preserves redo history until a new edit and refreshes restored tables.
Adds regression coverage for undo, redo, and history branching.

File	Description
test/00/godleyTable.sh	Adds popup history regression tests.
model/godleyTableWindow.cc	Records edits and revises history restoration.
model/godleyIcon.cc	Captures history before cell and row changes.
gui-js/libs/ui-components/src/lib/godley-widget-view/godley-widget-view.component.ts	Records HTML row and column operations.
gui-js/apps/minsky-electron/src/app/managers/GodleyMenuManager.ts	Refreshes popups after Undo and Redo.

_{Review effort: Balanced}

Copilot · 2026-10-20T04:06:20Z

+            await godley.popup.undo(1);
+            GodleyMenuManager.refresh(window);


Fixed in dbec42327: Undo/Redo now routes through the renderer, commits the active cell edit, then invokes backend history navigation and refresh.

Copilot · 2026-10-20T04:06:47Z

  void GodleyIcon::moveCell(const MoveCellArgs& args)
  {
    if (!table.cellInTable(args.srcRow, args.srcCol) || !table.cellInTable(args.destRow, args.destCol)) return;
+    popup.pushHistory();


Implemented in 486227f: cross-column moves now record one history transaction while both cell updates still perform linked-column balancing. Added an Undo regression test.

+        m_godleyIcon.table=restoredTable;
+        m_godleyIcon.update();
+        m_godleyIcon.table=restoredTable;
+        adjustWidgets();


highperformancecoder · 2026-10-20T01:39:53Z

@CodeRabbit - why are you skipping the review?

coderabbitai · 2026-10-20T01:40:17Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

⚙️ CodeRabbit configuration inspected

Length of output: 98174

@highperformancecoder The two requests returned different levels of detail:

review: The response cited incremental-review restrictions. This command does not re-review already reviewed commits and applies only when automatic reviews are paused.
rereview: The response said only “Review skipped.” I checked the configuration, but the result contains no execution diagnostics that explain this skip.

Automatic and incremental reviews are enabled. No path, title, label, or username exclusion filters are configured.

My earlier reply announced a full re-review, but the action did not complete. Sorry for the confusion. Please try @coderabbitai full review. If that also skips without a reason, contact CodeRabbit support with the link to #1018 so they can inspect the execution logs.

You are interacting with an AI system.

highperformancecoder · 2026-10-20T01:41:01Z

@coderabbitai full review

coderabbitai · 2026-10-20T01:41:07Z

⚠️ Action not completed

Review skipped.

… stock var's initial conditions.

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

Initial plan

bdce416

Copilot AI assigned Copilot and highperformancecoder Oct 18, 2026

Copilot started work on behalf of highperformancecoder October 18, 2026 22:16

View session

Copilot AI linked an issue Oct 18, 2026 that may be closed by this pull request

[SF#1366] undo/redo not working in Godley popup #804

Open

Fix Godley popup undo and redo history

03c5a25

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix undo/redo functionality in Godley popup~~ Restore undo and redo in Godley popups Oct 18, 2026

Copilot finished work on behalf of highperformancecoder October 18, 2026 22:26

Copilot AI requested a review from highperformancecoder October 18, 2026 22:26

Copilot started work on behalf of highperformancecoder October 20, 2026 00:33

View session

Keep Godley redo history after table refresh

4268541

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

Copilot finished work on behalf of highperformancecoder October 20, 2026 00:38

highperformancecoder marked this pull request as ready for review October 20, 2026 01:30

Copilot AI balanced review requested due to automatic review settings October 20, 2026 01:30

Copilot started reviewing on behalf of highperformancecoder October 20, 2026 01:31

View session

highperformancecoder approved these changes Oct 20, 2026

View reviewed changes

Copilot AI reviewed Oct 20, 2026

View reviewed changes

bugfix: undo of godley table clearing initial conditions should clear…

dd37bd6

… stock var's initial conditions.

Copilot started work on behalf of highperformancecoder October 20, 2026 03:36

View session

Copilot AI requested a review from highperformancecoder October 20, 2026 03:37

Copilot finished work on behalf of highperformancecoder October 20, 2026 03:38

Copilot started work on behalf of highperformancecoder October 20, 2026 03:56

View session

Copilot started work on behalf of highperformancecoder October 20, 2026 03:57

View session

Copilot AI and others added 2 commits October 20, 2026 04:01

Commit active Godley edit before undo

dbec423

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

Make Godley cross-column moves a single undo step

486227f

Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>

Copilot finished work on behalf of highperformancecoder October 20, 2026 04:07

Copilot finished work on behalf of highperformancecoder October 20, 2026 04:08

		await godley.popup.undo(1);
		GodleyMenuManager.refresh(window);

Conversation

Copilot AI commented Oct 18, 2026 • edited by highperformancecoder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

highperformancecoder commented Oct 20, 2026

Uh oh!

Copilot AI commented Oct 20, 2026

Uh oh!

highperformancecoder commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highperformancecoder commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

highperformancecoder commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026

Uh oh!

highperformancecoder commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 18, 2026 •

edited by highperformancecoder

Loading

coderabbitai Bot commented Oct 18, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading