Repository navigation
Upgrade javafx-controls to 27.0.1 on JDK 25 - #41
Merged
Merged
Conversation
JavaFX 27 is compiled for JDK 25, so the compiler release, CI, and docs move with it. Spotless needs google-java-format 1.30.0 to run on that JDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaFX 27.0.1 is built with
--release 25, so a version-only bump does not compile on JDK 21. This moves the project to JDK 25 and upgradesjavafx-controlsfrom 21.0.6 to 27.0.1.maven.compiler.releaseis 25 (class files are major version 69).setup-javauses Temurin 25.google-java-formatis 1.30.0, the minimum that plugin accepts on JVM 25. Source formatting is unchanged.Local
mvn -B spotless:check compile testpasses on JDK 25 (5 tests).mvn javafx:runstarts the JavaFX runtime. This supersedes the version-only Dependabot update and leaves that pull request open.