test(ci-wiring): assert the gate's remaining error branches and clear its coverage-floor entry by hivecommons-hive[bot] · Pull Request #300 · hivecommons/hivecommons.github.io

hivecommons-hive · 2026-10-29T14:15:48Z

Summary

Clears the scripts/ci-wiring.test.mjs entry from TEST_HELPER_BASELINE in scripts/coverage-floor.test.mjs (6 → 0 dead ranges), continuing the per-file burn-down started in #288 and carried on by #292 and #294.

Why these branches matter: wiringProblems' no-jobs guard and triggerProblems' missing-on:/missing-push: fallbacks are exactly the cases where a mangled links.yml would otherwise let the gate pass vacuously, and the nodeSources-absent fallbacks decide whether an unreadable *.test.mjs is reported or waved through. None of them had an assertion; the ratchet only knew they were never executed.

One range could not be asserted into life: the ?? "" after the block-scalar regex in runCommands is unreachable (a (...)* capture group always matches, so .exec(...)[1] is at worst ""). It is dropped and the behaviour it was guarding — an empty run: | yields one empty command — is pinned by a test instead, so the result cannot drift silently.

Without the baseline change the ratchet fails with scripts/ci-wiring.test.mjs: 0 dead ranges left, baseline allows 6 — lower TEST_HELPER_BASELINE to nothing (delete the entry); without the new assertions it fails the other way. Verified both locally.

No page, redirect or workflow content changes.

Screenshots

n/a — test-only change.

Checks run locally

node --test scripts/*.test.mjs (795 pass)
scripts/check-links.sh --external-warn (192 links, 0 errors)
scripts/check-links.test.sh
scripts/check-redirects.test.sh
scripts/check-redirects.sh

Checklist

Shortcut redirects were changed only through the MAP in make-redirects.sh (none changed)
No inline <script> edited
No new top-level page
No change to integration or sponsor lists
Commits are signed off (git commit -s)

Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

… its coverage-floor entry wiringProblems' no-jobs guard, triggerProblems' missing on:/push: fallbacks and the nodeSources-absent fallbacks in the node:test naming rules ran under the suite only when a page happened to hit them; nothing asserted what they decide. The `?? ""` after the block-scalar regex could never fire (a `*` group always matches), so it is dropped and the empty-block result pinned instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

kubestellar-prow · 2026-10-29T14:15:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hivecommons-hive