Skip to content

Keep host names out of files that handle the API key #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddietejeda merged 1 commit into from
Oct 27, 2026
Merged

Keep host names out of files that handle the API key #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/hotdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def run(args: Sequence[str], timeout: int = TIMEOUT) -> str:
)
except FileNotFoundError:
raise HotdataError("the `hotdata` CLI is not on PATH: install it with "
"`brew install hotdata-dev/tap/cli` (other ways: "
"https://github.com/hotdata-dev/hotdata-cli#install), then "
"`brew install hotdata-dev/tap/cli` (other ways: see the "
"plugin README), then "
"`hotdata auth login`") from None
except subprocess.SubprocessError as error:
raise HotdataError(str(error)) from None
Expand Down
2 changes: 1 addition & 1 deletion tests/test_tabular_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def out(o): print(json.dumps(o))
"sql_hash": "h4", "result_id": "rsltHK", "row_count": 1, "snapshot_id": 7, "status": "succeeded"}])
elif a[:2] == ["auth", "status"]:
if __import__("os").environ.get("FAKE_AUTH_BROKEN"):
print("error: could not reach https://api.hotdata.dev", file=sys.stderr); sys.exit(1)
print("error: could not reach the Hotdata API", file=sys.stderr); sys.exit(1)
ok = "No" if __import__("os").environ.get("FAKE_LOGGED_OUT") else "Yes"
print(f"\x1b[38;5;8mAuthenticated: \x1b[0m{ok}")
elif a == ["--version"]:
Expand Down
Loading