Skip to content

docs: add Signed commits section to CONTRIBUTING - #101

Merged
hyperpolymath merged 2 commits into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4a80f7b3-40b5-48aa-b1be-a516dde3159e

📥 Commits

Reviewing files that changed from the base of the PR and between 83f272f and 128113a.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (27)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: trufflehog
  • GitHub Check: Groove manifest check
  • GitHub Check: rust-secrets
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: PR (address)
  • GitHub Check: gitleaks
  • GitHub Check: Validate K9 contracts
  • GitHub Check: analyze (actions, none)
🔇 Additional comments (1)
CONTRIBUTING.adoc (1)

110-125: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added contribution guidance requiring commits to the default branch to meet the estate signing policy.
    • Explained signing requirements for people, interactive agents, apps, bots and workflows, along with the required PR merge approach.

Walkthrough

The contribution guidance adds signed-commit requirements for commits reaching the default branch. It describes signing methods for people and automated contributors, and specifies branch and merge requirements.

Changes

Signed Commit Guidance

Layer / File(s) Summary
Signing and merge requirements
CONTRIBUTING.adoc
The guidance describes signing requirements and methods, commit checks on pull request branches, squash merges, and how to replace unsigned commits. It notes that rebase-merge is disabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 12811

This documentation-only change aligns with the cited signing policy and documented PR signature checks. No merge-blocking risk is established; the repository-specific ruleset setting remains unknown.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 12811

The change documents contribution identity and merge requirements without changing executable controls. No introduced security weakness was established, but the actual signing ruleset and merge configuration could not be independently confirmed.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The supported scope is this repository's contribution and default-branch integration policy. The changed surface does not show new credentials, expanded automation permissions, or a new cross-service execution path.

Trust Boundaries and Controls

  • observed — The document places merge eligibility behind a stated signed-commit ruleset and says rebase merging is disabled. These external controls are asserted by the guidance; their active configuration and bypass permissions were not independently established.

Resilience and Maintainability Implications

  • inferred — The recovery instruction retains signed commits and creates a new PR rather than prescribing a privileged bypass. It does not establish authorization, cleanup, approval handling, or concurrency behavior for interrupted or repeated recovery attempts. No automated recovery implementation is introduced, so these omissions remain limits on the assessment rather than demonstrated security failures.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a Signed commits section to CONTRIBUTING.
Description check ✅ Passed The description accurately explains the documentation change, its signing requirements, merge method, policy reference, and docs-only scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each commit’s mark,
Signed keys shine against the dark.
Squash the branch and make it neat,
Signed commits hop on steady feet.
The rabbit nibbles, pleased with the feat.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@hyperpolymath
hyperpolymath merged commit 2923eea into main Oct 1, 2026
2 of 3 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant