Repository navigation
Accept hyper-voice for noise suppression - #12
Merged
Merged
Conversation
jlnstrk
force-pushed
the
jlnstrk/noise-suppression-values
branch
from
October 22, 2026 04:14
507eb8c to
e81dc74
Compare
jlnstrk
changed the title
hyper-voice and dpdfnet2 for noise suppressionhyper-voice for noise suppression
rksm
approved these changes
Oct 23, 2026
hyper.video's noise suppression setting takes `none` and `hyper-voice`. The simulator checks `--noise-suppression` and the `noise_suppression` config key against engines hyper.video no longer offers, so it rejects `hyper-voice` and can't select it. - `NoiseSuppression` holds exactly `none` and `hyper-voice`. The default stays `none`. Local and AWS Device Farm participants pass the value to hyper.video as before. - A config file that names an old engine loads it as `none`, with a warning, as hyper.video drops stored values that it doesn't take. The CLI and `--participant` JSON reject an old engine. - The Cloudflare worker's schema takes `none` and 16 old engines, but not `hyper-voice`. Its backend sends `none` in place of `hyper-voice`, with a warning, and refuses a runtime change to it. When the worker reports an old engine, the backend reports `none`, with a warning.
jlnstrk
force-pushed
the
jlnstrk/noise-suppression-values
branch
from
October 23, 2026 14:02
daeac43 to
82de68b
Compare
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the simulator's
--noise-suppressionoption andnoise_suppressionconfig key takenoneand a list of engines that hyper.video no longer offers. hyper.video's noise suppression setting takesnoneandhyper-voice, so the simulator rejectshyper-voiceand can't select it, and the engines it offers never apply.NoiseSuppressionholds exactlynoneandhyper-voice, and the default staysnone. Local and AWS Device Farm participants pass the value to hyper.video as before, and current hyper.video applies it once Edit Hyper Core settings throughhyper.settings.client#13 moves the settings commands tohyper.settings.client.nonewith a warning, as hyper.video drops stored values that it doesn't take. The CLI and--participantJSON reject an old engine.nonein place ofhyper-voice, with a warning, and refuses a runtime change to it. The worker's schema takesnoneand 16 old engines, but nothyper-voice, so Cloudflare participants run without noise suppression until it does.none, with a warning.A CLI call or
--participantJSON that names another engine now fails to parse. Usenoneorhyper-voice. A config file that names one still loads, withnoneand a warning.