docs: fix version-bump commit counting - #2
Conversation
git log --oneline prefixes each line with the hash, so no line starts with feat:/fix: and the version-bump thresholds could never trigger. Use --format=%s. Where the repo has no Rule 6, describe the human sign-off directly instead of pointing at a rule that is not there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe automatic version-bump instructions now list commit subjects without hashes. A note explains that hashes in ChangesVersion-bump instructions
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The updated instruction supports counting Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
The version-bump rule counts commits with
git log <last-tag>..<branch> --onelineand then counts lines starting withfeat:orfix:.--onelineputs the short hash first on each line, so no line ever starts withfeat:orfix:, and the "5 or more" thresholds can never trigger. CodeRabbit caught this on i-machine-things/wl-tools#13.What
--format='%s', which prints subjects only.Tested: in a scratch repo with
feat:,fix:andchore:commits,--format=%s | grep -c ^feat:gives 1 and--oneline | grep -c ^feat:gives 0.🤖 Generated with Claude Code
Summary by CodeRabbit