Skip to content

docs: fix version-bump commit counting - #2

Merged
i-machine-things merged 1 commit into
masterfrom
docs/fix-version-bump-count
Sep 27, 2026
Merged

i-machine-things merged 1 commit into
masterfrom
docs/fix-version-bump-count

Conversation

@i-machine-things

@i-machine-things i-machine-things commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Why

The version-bump rule counts commits with git log <last-tag>..<branch> --oneline and then counts lines starting with feat: or fix:. --oneline puts the short hash first on each line, so no line ever starts with feat: or fix:, and the "5 or more" thresholds can never trigger. CodeRabbit caught this on i-machine-things/wl-tools#13.

What

  • Switches the counting command to --format='%s', which prints subjects only.
  • Where this repo has no Rule 6, drops the pointer to it and describes the human sign-off before tagging directly.

Tested: in a scratch repo with feat:, fix: and chore: commits, --format=%s | grep -c ^feat: gives 1 and --oneline | grep -c ^feat: gives 0.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated release-maintenance guidance to identify feature and bug-fix commit subjects more clearly. This supports more consistent version recommendations; no user-facing functionality or behavior changes in this update.

git log --oneline prefixes each line with the hash, so no line starts
with feat:/fix: and the version-bump thresholds could never trigger.
Use --format=%s. Where the repo has no Rule 6, describe the human
sign-off directly instead of pointing at a rule that is not there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 72bac4a3-e9a5-4042-ad1d-b02b9af1abd3

📥 Commits

Reviewing files that changed from the base of the PR and between ea21554 and 9238eda.

📒 Files selected for processing (1)
  • .claude/CLAUDE.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The automatic version-bump instructions now list commit subjects without hashes. A note explains that hashes in --oneline output prevent matching commit-type prefixes.

Changes

Version-bump instructions

Layer / File(s) Summary
List commit subjects for prefix matching
.claude/CLAUDE.md
The instructions use git log --format='%s' instead of --oneline. The note explains that hashes prevent matching feat: and fix: prefixes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 9238e

The updated instruction supports counting feat: and fix: commit subjects. No actionable merge-blocking issue is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 9238e

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .claude/CLAUDE.md: The commit-list command now outputs commit subjects only using --format='%s', replacing --oneline; the accompanying note explains that hashes from --oneline would prevent matching commit-type prefixes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: correcting version-bump commit counting in documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@i-machine-things
i-machine-things merged commit 7408297 into master Sep 27, 2026
5 checks passed
@i-machine-things
i-machine-things deleted the docs/fix-version-bump-count branch September 27, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant