[jlsync]

Summary of Improvements

This PR introduces several non-invasive, backward-compatible performance optimizations across routing helpers, request introspection, and controller lifecycle methods:

1. Routing Helpers (NamedRouteHelper):

   • Replaced array concatenation args + [options] with in-place append args << options unless options.empty?.
   • Replaced args = [resource] + args with in-place prepend args.unshift(resource).
   • Replaced temporary array concatenation *(enclosing_collection_resources + args) with Ruby multi-splat argument dispatch *enclosing_collection_resources, *args.
   • Replaced resource_method.match?(/enclosing_resource/) with resource_method.include?('enclosing_resource').
   • Optimized suffix stripping (delete_suffix) and route mapping lookups.

2. Request Path Introspection (RequestPathIntrospection):

   • Cached compiled lookahead regular expressions in remove_current_segment via SEGMENT_REGEXPS, eliminating runtime regex compilation on each request.
   • Refactored param_keys to a single-pass params.each_key.filter_map to eliminate intermediate arrays.
   • Replaced path[1..-1].to_s.split('/') with path.delete_prefix('/').split('/').
   • Used delete_suffix('_id') in segment_for_key instead of range slicing 0..-4.

3. Instance Variable Access & Controller Lifecycle (ResourcesController & Specification):

   • Precomputed ivar Symbols (@ivar_name = :"@#{name}", @collection_ivar_name = :"@#{plural}") in Specification#initialize, avoiding string interpolation and symbol interning on every call to resource, resource=, resources, and resources=.
   • Modernized hand-rolled accessors resource_service= and enclosing_resource_name to attr_writer and attr_reader for C-level VM dispatch and YJIT inline caching.
   • Replaced /\A\?(.*)/ regex matching in load_enclosing_resources with fast prefix check spec.is_a?(String) && spec.start_with?('?').
   • Replaced temporary Hash allocation in load_wildcards_from with a block check.
   • Used symbol :@enclosing_resource_name in instance_variable_set.

4. Parameters & Form Helpers (ResourceMethods & Helper):

   • In resource_params, used params.fetch(resource_name) { {} } to avoid allocating unused Hash instances, and extracted frozen constant EXCLUDED_PARAM_COLUMNS = %w[updated_at created_at].freeze.
   • In Helper#form_for_resource_options, replaced resource_path(*([resource] + args)) with direct argument passing resource_path(resource, *args).

Test Suite Verification

All 658 examples pass with 0 failures:

$ bundle exec rspec
Finished in 3.34 seconds (files took 1.15 seconds to load)
658 examples, 0 failures

Co-authored-by: Antigravity antigravity@google.com

[jlsync]

@codex review